Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #10523

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix compile error #10523

merged 1 commit into from
Sep 4, 2020

Conversation

keithc-ca
Copy link
Contributor

  • use J9UTF8_DATA_EQUALS
  • initialize local variables

Fixes: #10522.

* use J9UTF8_DATA_EQUALS
* initialize local variables

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Copy link
Contributor Author

Jenkins compile aix,osx jdk8

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga DanHeidinga merged commit bb37145 into eclipse-openj9:master Sep 4, 2020
@keithc-ca keithc-ca deleted the cast branch September 4, 2020 14:50
@hangshao0
Copy link
Contributor

I see the original condition is replaced with J9UTF8_DATA_EQUALS, shouldn't it be !J9UTF8_DATA_EQUALS ?

@keithc-ca
Copy link
Contributor Author

Yes, I think you're right. Thanks for catching that. I'll create a new pull request to fix it.

keithc-ca added a commit to keithc-ca/openj9 that referenced this pull request Sep 8, 2020
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
DanHeidinga added a commit that referenced this pull request Sep 8, 2020
dusanboskovic pushed a commit to dusanboskovic/openj9 that referenced this pull request Sep 9, 2020
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vrfyhelp.c failed to compile on all Mac-OpenJ9 builds
3 participants