WIP: Simplify containsPrepareForOSR check #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want the option of enabling verification of the flag under debug for sanity? |
ncough
force-pushed
the
containsPrepareForOSR
branch
2 times, most recently
from
f44a21e
to
0ac1a74
Compare
|
I have added the verification check back in, under the debug flag. |
OSR data flow analysis must skip OSR blocks. This includes blocks that contain prepareForOSR calls. However, the check for these blocks consisted of a walk across its trees. It is cheaper to check the OSRBlock flag, as prepareForOSR calls must only appear in such blocks. Signed-off-by: Nicholas Coughlin <cnic@ca.ibm.com>
ncough
force-pushed
the
containsPrepareForOSR
branch
from
0ac1a74
to
67aa343
Compare
|
Jenkins test sanity |
|
@AdamBrousseau something up with 390 again looks to me like the failure isn't related to this code - I'd like to merege if we think things are clean. |
|
Jenkins test sanity |
andrewcraik
reviewed
Oct 2, 2017
| @@ -39,18 +39,26 @@ bool TR_FearPointAnalysis::virtualGuardsKillFear() | |||
| return feGetEnv("TR_FPAnalaysisGuardsDoNotKillFear") == NULL; | |||
| } | |||
|
|
|||
| static bool containsPrepareForOSR(TR::Block *block) | |||
| bool TR_FearPointAnalysis::containsPrepareForOSR(TR::Block *block) | |||
There was a problem hiding this comment.
Since this function is called from two analyses would it be better somewhere in the OSR infrastructure?
ncough
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSR data flow analysis must skip OSR blocks. This
includes blocks that contain prepareForOSR calls.
However, the check for these blocks consisted of
a walk across its trees. It is cheaper to check
the OSRBlock flag, as prepareForOSR calls must
only appear in such blocks.