Change default -Xthr:spin1 value for PPC64BE #10636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pls provide the details of the compiler versions which changed and caused the problem. I see this change affects both AIX and plinux, and isn't specific to a version of Java. Possibly it needs to be more specific. These are the current versions used to build: plinux BE xlC 13.1 "recently" changed from 12.1 from SR6 FP5 |
zl-wang
requested changes
Sep 17, 2020
Currently the xlC compiler generates a bunch of extra nops in the spinOnFlatLock routine, throwing off the spinning timing and causing a ~5% regression. This change modifies the default spin count to 151 for PPC64BE (previously 96 for all PPC machines), which restores the proper timing and fixes the regression. Signed-off-by: Jackie Midroni <jackie.midroni@mail.utoronto.ca>
@pshipton My bad, my description wasn't clear enough. This regression was caused by this change (eclipse/omr@6cbc638), not by a change to the version of xlC used |
zl-wang
approved these changes
Sep 18, 2020
pshipton
approved these changes
Sep 18, 2020
|
jenkins compile plinux jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the xlC compiler generates a bunch of extra nops in the spinOnFlatLock routine, throwing off the spinning timing and causing a ~5% regression. This change modifies the default spin count to 151 for PPC64BE (previously 96 for all PPC machines), which restores the proper timing and fixes the regression.
Signed-off-by: Jackie Midroni jackie.midroni@mail.utoronto.ca