Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce AOT load failures with SVM enabled #10644

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Reduce AOT load failures with SVM enabled #10644

merged 3 commits into from
Sep 18, 2020

Commits on Sep 17, 2020

  1. Refactor isClassWorthRemembering 

    Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
    @dsouzai
    dsouzai committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    690a164 View commit details
    Browse the repository at this point in the history

  2. Add StringBuffer to classes not worth remembering in SVM 

    Newer java code is moving towards using StringBuilder. Therefore,
ignoring this class reduces load failures, while having minimal
impact on steady state throughput.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
    @dsouzai
    dsouzai committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    d95d8c0 View commit details
    Browse the repository at this point in the history

  3. Check if class is worth remembering in other SVM APIs 

    addMethodRecord and addClassInfoIsInitialized never checked if the class
(or the class of the method in the case of the former) were worth
remembering. This led to several AOT load failures. Filtering out the
methods not worth remembering in these APIs reduce AOT load failures.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
    @dsouzai
    dsouzai committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    7c2f23a View commit details
    Browse the repository at this point in the history