-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests of JEP 360 & 384 for Java 16+ #10835
Enable tests of JEP 360 & 384 for Java 16+ #10835
Conversation
3f9d858
to
296b4d8
Compare
Fixes eclipse-openj9#10243 Signed-off-by: Alexey Anufriev <contact@alexey-anufriev.com>
296b4d8
to
d883b52
Compare
hi @pshipton, |
Do the tests pass if enabled? If so they can be enabled until something changes. |
jenkins test sanity zlinux jdknext |
@pshipton, hm, unfortunately, I did not get the reason of failure, where can I see failed tests? |
You enabled 2 tests (called Jep360Tests and Jep384Tests, so you can look for those 2 test targets in the TAP output of the Jenkins job that runs them. How do you find the job? Above there is a link to the parent pipeline that would have launched the tests, click on Details to take you to the parent: It takes you to the parent Jenkins job, at the bottom of the page, there is a link to a child job that is 'not stable', which means tests failed: Click on the unstable child Job link that and look at the test output via the TAP Extended Test Results view to see that Jep360Tests target failed (and it shows console output) Or in the case of these particular tests which produce Junit output, you can also look at the Test results view, which will show you the 9 individual test cases within the Jep360Tests target failed. |
Jep384Tests_0 did pass. |
@smlambert, @pshipton, yes, looks like sealed classes are not in 16 yet. In fact, I have seen a couple of related PR being merged, that is why suspected that it might be in 16. Then I will close the PR. Thank you for your help. |
Closing for now. |
FYI #11606 (comment) |
hi @pshipton, |
Turns out we won't need this PR. I did re-try the tests in #11606 (comment). Mike added both of the changes to that PR, the testing is passing with that PR (#11606 (comment)), so these changes will get applied when #11606 is merged. |
Re-enable back tests of JEP 360 & 384 for Java 16+ that were disabled in #10243