Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests of JEP 360 & 384 for Java 16+ #10835

Conversation

alexey-anufriev
Copy link
Contributor

@alexey-anufriev alexey-anufriev commented Oct 8, 2020

Re-enable back tests of JEP 360 & 384 for Java 16+ that were disabled in #10243

@alexey-anufriev alexey-anufriev force-pushed the enable-jep360-jep384-tests-for-java-16-and-up branch from 3f9d858 to 296b4d8 Compare October 8, 2020 14:11
Fixes eclipse-openj9#10243

Signed-off-by: Alexey Anufriev <contact@alexey-anufriev.com>
@alexey-anufriev alexey-anufriev force-pushed the enable-jep360-jep384-tests-for-java-16-and-up branch from 296b4d8 to d883b52 Compare October 8, 2020 22:30
@alexey-anufriev alexey-anufriev changed the title WIP: Enable tests of JEP 360 & 384 for Java 16+ Enable tests of JEP 360 & 384 for Java 16+ Oct 8, 2020
@alexey-anufriev
Copy link
Contributor Author

hi @pshipton,
wanted to know your opinion if we can enable these tests back?

@pshipton
Copy link
Member

pshipton commented Oct 9, 2020

Do the tests pass if enabled? If so they can be enabled until something changes.

@pshipton
Copy link
Member

pshipton commented Oct 9, 2020

jenkins test sanity zlinux jdknext

@alexey-anufriev
Copy link
Contributor Author

@pshipton, hm, unfortunately, I did not get the reason of failure, where can I see failed tests?

@smlambert
Copy link
Contributor

You enabled 2 tests (called Jep360Tests and Jep384Tests, so you can look for those 2 test targets in the TAP output of the Jenkins job that runs them. How do you find the job? Above there is a link to the parent pipeline that would have launched the tests, click on Details to take you to the parent:
Screen Shot 2020-10-09 at 2 29 28 PM

It takes you to the parent Jenkins job, at the bottom of the page, there is a link to a child job that is 'not stable', which means tests failed:

Screen Shot 2020-10-09 at 2 31 50 PM

Click on the unstable child Job link that and look at the test output via the TAP Extended Test Results view to see that Jep360Tests target failed (and it shows console output)

Or in the case of these particular tests which produce Junit output, you can also look at the Test results view, which will show you the 9 individual test cases within the Jep360Tests target failed.

Screen Shot 2020-10-09 at 2 37 02 PM

@pshipton
Copy link
Member

pshipton commented Oct 9, 2020

Jep384Tests_0 did pass.

@alexey-anufriev
Copy link
Contributor Author

@smlambert, @pshipton, yes, looks like sealed classes are not in 16 yet. In fact, I have seen a couple of related PR being merged, that is why suspected that it might be in 16.

Then I will close the PR.

Thank you for your help.

@alexey-anufriev
Copy link
Contributor Author

Closing for now.

@pshipton
Copy link
Member

pshipton commented Jan 8, 2021

FYI #11606 (comment)

@pshipton pshipton closed this Jan 8, 2021
@alexey-anufriev
Copy link
Contributor Author

hi @pshipton,
do you think we can reopen this PR to try the tests again?

@pshipton
Copy link
Member

pshipton commented Jan 11, 2021

Turns out we won't need this PR. I did re-try the tests in #11606 (comment). Mike added both of the changes to that PR, the testing is passing with that PR (#11606 (comment)), so these changes will get applied when #11606 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants