Fix tracepoint specifiers

[JasonFengJ9]

Changed %llx/%llu to %zx/%zu for UDATA.

Signed-off-by: Jason Feng fengj@ca.ibm.com

[JasonFengJ9]

@gacholio could you please review?

[gacholio]

I don't think you need to obsolete tracepoints when changing the formats here. Fixing them in place should be fine - the old tracepoints either worked or they didn't, the new formats are presumably correct.

@keithc-ca Any comments?

[JasonFengJ9]

As per the rules for adding tracepoint definitions to TDF files:
If a tracepoint's signature changes, OBSOLETE IT AND CREATE A NEW ONE. By signature we mean the types, order and total number of format specifiers in the Template. Changes to the Tracepoint Type, Overhead, Level and NoEnv parameters, and cosmetic changes to the text in the Template can be made without adding a new tracepoint.
Technically this PR modifies the type which falls into the signature change category, however I do agree that

Fixing them in place should be fine - the old tracepoints either worked or they didn't, the new formats are presumably correct.

Just for the record, the tracepoints in question went in ~2 month ago, so the impact was only in last release cycle.

[gacholio]

The "signature" of the tracepoints are not changing - you're just correcting the specifiers. The only possible issue I see is having the updates make it into the translations. This would be a poor reason for duplicating the tracepoints (you could update the translations yourself if this is going to be an issue).

[pshipton]

Yes, if they are already translated then the translations should be updated as well. Not sure if a future translation pass would pick up the change. Also it will be ~8 months before another translation pass occurs.

[JasonFengJ9]

Yes, if they are already translated then the translations should be updated as well. Not sure if a future translation pass would pick up the change. Also it will be ~8 months before another translation pass occurs.

How do we know if the translations for the last release have been done?

[pshipton]

How do we know if the translations for the last release have been done?

Ya, actually these are tracepoints, they don't get translated. Some confusion with NLS messages here.

[JasonFengJ9]

Modified the specifier within current tracepoints, please have another look.

[keithc-ca]

I did a few spot checks. The changes look good to me.

[keithc-ca]

Jenkins test sanity win32 jdk8

[keithc-ca]

Jenkins test sanity zlinux jdk11

[gacholio]

Sorry for the translation confusion.