Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a stub for NativeMethodHandle in JDK16 #11267

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

babsingh
Copy link
Contributor

fixes: #11255

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

@babsingh
Copy link
Contributor Author

I tried to turn-on the opt_panama and Panama (JCL) flags in order to enable the OpenJ9 NativeMethodHandle support. But, I ended up facing many issues:

  1. jdk.internal.nicl and java.nicl packages no longer exist in JDK16. Finding their new equivalent representation will take some time.
  2. MethodHandles class no longer has the findNative* methods.
  3. Library class is no longer available; potentially renamed to NativeLibrary and relocated.
  4. gcc error: Jit.hpp in JavaMethodCallbackGen.cpp cannot be found.
  5. ... the list goes on

The above conflicts cannot be resolved quickly. So, I have added a minimal stub for the NativeMethodHandle class, which should allow us to quickly enable JDK16 builds.

@babsingh
Copy link
Contributor Author

babsingh commented Nov 24, 2020

Suggested PR builds:

Jenkins test sanity xlinux jdk11
Jenkins test sanity xlinux jdknext
Jenkins test zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

All builds should pass. The jdknext openj9 build will fail because the NativeEntryPoint class only exists in the jdknext openj9-staging branch at this point.

@babsingh
Copy link
Contributor Author

@tajila
Copy link
Contributor

tajila commented Nov 24, 2020

Jenkins test sanity xlinux jdk11

@tajila
Copy link
Contributor

tajila commented Nov 24, 2020

Jenkins test sanity plinux jdknext

@tajila
Copy link
Contributor

tajila commented Nov 24, 2020

Jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

fixes: eclipse-openj9#11255

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

babsingh commented Nov 24, 2020

All the recent feedback has been addressed. Unfortunately, the jdknext openj9 build will be unsuccessful since NativeEntryPoint only exists in jdknext openj9-staging at this point.

@keithc-ca
Copy link
Contributor

Jenkins test sanity xlinux jdk11

@keithc-ca
Copy link
Contributor

Jenkins test sanity zlinux jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging

@keithc-ca keithc-ca merged commit a3d9657 into eclipse-openj9:master Nov 25, 2020
@babsingh babsingh deleted the nativemethodhandle branch January 29, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK16 missing NativeMethodHandlemethods
4 participants