Prune constructors from NPE stack trace #11283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify pruneConstructors = true for NPE iterateStackTrace; Also exclude java/lang/NullPointerException.fillInStackTrace() from JIT compilation to keep the stack frame consistent. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
|
@gacholio could you please review? |
|
jenkins test sanity plinux,zlinux,win jdk15 |
|
@fjeremic can someone review from the JIT perspective pls. |
|
Oops, ran the wrong tests. jenkins test sanity.system plinux,zlinux,win jdk15 |
gacholio
approved these changes
Nov 26, 2020
|
The JIT has to transition to the interpreter to run the |
fjeremic
approved these changes
Nov 26, 2020
|
The Windows TestJlmRemoteMemoryNoAuth_0 failure is a known problem which is unrelated to this PR. |
|
Test re-included via adoptium/aqa-systemtest#382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify
pruneConstructors = trueforNPEiterateStackTrace();Also exclude
java/lang/NullPointerException.fillInStackTrace()from JIT compilation to keep the stack frame consistent.MauveMultiThreadLoadTest_0passed in 50x grinder atxa64&ap64platforms.closes #11206
Signed-off-by: Jason Feng fengj@ca.ibm.com