Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ROMClass walkers in DDR and VM consistent #11362

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Make ROMClass walkers in DDR and VM consistent #11362

merged 2 commits into from
Jan 29, 2021

Conversation

AlexeyKhrabrov
Copy link
Contributor

@AlexeyKhrabrov AlexeyKhrabrov commented Dec 3, 2020 •
edited

This PR updates DDR ROMClass walker to match recent changes in the other ROMClass walker (the one used by VM code and cfdumper) in #11330:

  • Method parameter names are handled as UTF8 strings rather than raw SRPs.
  • Strings in method debug info are visited as SRPs rather than direct pointers to J9UTF8.

Note: this PR should be merged after #11330.

@AlexeyKhrabrov AlexeyKhrabrov mentioned this pull request Dec 3, 2020
Merged
@AlexeyKhrabrov AlexeyKhrabrov marked this pull request as ready for review December 4, 2020 20:08
@tajila
Copy link
Contributor

tajila commented Dec 8, 2020

Jenkins test sanity,extended win jdk8

@tajila
Copy link
Contributor

tajila commented Dec 8, 2020

Jenkins test sanity,extended win jdk11

@AlexeyKhrabrov
Fix slot type for method parameter name in DDR ROMClass walker
23e2ca0 
Handle method parameter names as UTF8 strings rather than raw SRPs.

Signed-off-by: Alexey Khrabrov <khrabrov@cs.toronto.edu>
@AlexeyKhrabrov
Copy link
Contributor Author

Updated to modify runtime/ddr/overrides-vm and fix copyright years.

@tajila tajila requested a review from keithc-ca January 21, 2021 14:02
@tajila
Copy link
Contributor

tajila commented Jan 21, 2021

@keithc-ca please review these changes

@AlexeyKhrabrov
Use J9_ROM_UTF8 instead of J9_UTF8 in DDR ROMClass walker
10c3df5 
Match the ROMClass walk implementation used in VM and cfdumper in the
way it handles UTF8 strings in method debug info.

Signed-off-by: Alexey Khrabrov <khrabrov@cs.toronto.edu>
@keithc-ca
Copy link
Contributor

Jenkins test sanity,extended zlinux jdk8,jdk11

@keithc-ca keithc-ca merged commit fb38837 into eclipse-openj9:master Jan 29, 2021
@AlexeyKhrabrov AlexeyKhrabrov deleted the romclasswalk_ddr branch January 30, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexeyKhrabrov @tajila @keithc-ca