(0.24.0) Fix String equalsIgnoreCase() and regionMatches() implementations #11497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the javadoc, equalsIgnoreCase() and regionMatches()
both involve calling
`Character.toLowerCase(Character.toUpperCase(character))`
on each character in the string.
Add tests with Turkish characters for equalsIgnoreCase(),
regionMatches() and compareToIgnoreCase().
Use new helper charValuesEqualIgnoreCase() to compare if two
characters are equal (case insensitive).
[skip ci]
Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
sharon-wang
changed the title
pshipton
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #11423.