Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port testRASAPI into openj9 #11556

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Port testRASAPI into openj9 #11556

merged 1 commit into from
Jan 22, 2021

Conversation

OscarQQ
Copy link
Contributor

@OscarQQ OscarQQ commented Jan 3, 2021

related: backlog issue 426
[ci skip]

Signed-off-by: OscarQQ Yixin.Qian@ibm.com

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jan 3, 2021 •
edited
Loading

Build Platform Java Version JDK Impl
Internal Grinder/12904 ppc64_aix,ppc64le_linux,s390x_linux,x86-64_linux,x86-64_mac,x86-64_windows 8,11 OpenJ9

this pr will not affect vmfarm, only openj9 version will be tested

@llxia llxia added the comp:test label Jan 4, 2021
@OscarQQ OscarQQ marked this pull request as draft January 4, 2021 20:24
@OscarQQ OscarQQ force-pushed the testRASAPI branch 2 times, most recently from 9816753 to 05e24d1 Compare January 4, 2021 21:35
@OscarQQ OscarQQ marked this pull request as ready for review January 5, 2021 06:35
@llxia
Copy link
Contributor

llxia commented Jan 6, 2021

jenkins test extended all jdk8,jdk11

@llxia
Copy link
Contributor

llxia commented Jan 7, 2021

jenkins test extended osx jdk8,jdk11

@OscarQQ OscarQQ marked this pull request as draft January 7, 2021 20:24
@OscarQQ OscarQQ force-pushed the testRASAPI branch 3 times, most recently from b996da9 to dba973f Compare January 8, 2021 19:55
@llxia
Copy link
Contributor

llxia commented Jan 18, 2021

The test passed on ub16p8j92: https://ci.eclipse.org/openj9/job/Grinder/1424/

And it is failed on ub16-ppcle-2: https://ci.eclipse.org/openj9/job/Grinder/1425/console

00:10:49.868  /home/jenkins/jenkins-agent/workspace/Grinder/jvmtest/functional/RasapiTest/test.xml:65: taskdef class org.apache.tools.ant.taskdefs.optional.junit.JUnitTask cannot be found
00:10:49.868   using the classloader AntClassLoader[/home/jenkins/jenkins-agent/workspace/Grinder/jvmtest/functional/RasapiTest/junit4.jar]
00:10:49.868  
00:10:49.868  Total time: 0 seconds
00:10:49.868  
00:10:49.868  testRASAPI_0_FAILED

From here, the error is due to ant-junit.jar is missing.

@AdamBrousseau It looks like the above two ppcle machines are configured differently. Could we update ub16-ppcle-2? Thanks.

@OscarQQ OscarQQ marked this pull request as ready for review January 18, 2021 18:53
@AdamBrousseau
Copy link
Contributor

Updated the 3 plinux at OSU. These were set up long ago so they were on ant 1.9. Updated to 1.10 and ant-contrib 1.0b3. Please try again.

@llxia
Copy link
Contributor

llxia commented Jan 18, 2021

Thanks a lot @AdamBrousseau .
Reran on ub16-ppcle-2: https://ci.eclipse.org/openj9/job/Grinder/1428/

@OscarQQ
port testRASAPI into openj9
6bed3f4 
related: backlog issue 426
[ci skip]

Signed-off-by: OscarQQ <Yixin.Qian@ibm.com>
@llxia
Copy link
Contributor

llxia commented Jan 18, 2021

jenkins test extended all jdk8,jdk11

llxia
llxia approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjeremic
Copy link
Contributor

The first line should be less than 70 characters, where reasonable, and should be written in sentence case (capitalize the first letter) preferably not ending in a period.

https://github.com/eclipse/openj9/blob/master/CONTRIBUTING.md#commit-guidelines

I guess we already ran the testing on this one. Up to the committer to choose whether to merge or not. Just noting this for your future PRs.

@OscarQQ OscarQQ changed the title port testRASAPI into openj9 Port testRASAPI into openj9 Jan 21, 2021
@llxia llxia merged commit 8c1868d into eclipse-openj9:master Jan 22, 2021
@pshipton pshipton mentioned this pull request Jan 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OscarQQ @llxia @AdamBrousseau @fjeremic