JVM_LoadLibrary() must use lazy library loading by default #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasonFengJ9 pls review |
JasonFengJ9
reviewed
Jan 7, 2021
test/functional/cmdLineTests/defaultLazySymbolResolution/playlist.xml
Outdated
Show resolved
Hide resolved
Re-include cmdLineTester_defaultLazySymbolResolution for jdk15+ Issue eclipse-openj9#11076 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Jenkins test sanity,extended zlinux jdk11,jdk15 |
keithc-ca
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-include cmdLineTester_defaultLazySymbolResolution for jdk15+
Resolves #11076
See https://github.com/eclipse/openj9/blob/master/runtime/vm/vmbootlib.c#L182-L183
This is a change in behavior for OpenJ9, as prior to jdk15 bootstrap libraries don't use lazy resolution. However it matches the Hotspot behavior. Also note that libraries loaded early in bootstrap don't use lazy resolution since registerBootstrapLibrary() is still called. https://github.com/eclipse/openj9/blob/master/runtime/j9vm/jvm.c#L3686
Tested via personal build and grinder https://ci.eclipse.org/openj9/view/Test/job/Grinder/1355