Disable VAR_HANDLE_GUARDS optimization in OpenJ9 #11767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VAR_HANDLE_GUARDS optimization is disabled in OpenJ9. Refer to eclipse-openj9#11582 for more details on why this optimization needs to be disabled. VarHandles are only enabled in JDK11+ so the VAR_HANDLE_GUARDS system property only needs to be disabled in JDK11+. Related: eclipse-openj9#11582 Co-authored-by: Jack Lu <Jack.S.Lu@ibm.com> Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
@gacholio can you please review this PR? Also, needs to be tagged with |
gacholio
approved these changes
Jan 27, 2021
|
As there are no existing builds for this feature, and all the new code is under ifdef, I'm merging this. |
Running PR builds is not possible at this point. A number of PRs still need to be merged before PR builds can be launched. Once those PRs are merged, PR builds can be launched using one of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VAR_HANDLE_GUARDSoptimization is disabled in OpenJ9. Refer to#11582 for more details on why this optimization needs to be disabled.
VarHandlesare only enabled in JDK11+ so theVAR_HANDLE_GUARDSsystemproperty only needs to be disabled in JDK11+.
Related: #11582, #7352
Co-authored-by: Jack Lu Jack.S.Lu@ibm.com
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com