Compile AIX with -qstackprotect #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnakamura
approved these changes
Jun 3, 2021
hangshao0
approved these changes
Jun 3, 2021
|
jenkins test sanity,sanity.system,sanity.openjdk aix jdk8,jdk11,jdk16 |
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
To avoid xlc Internal abort on 32-bit with -qstackprotect Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
jenkins test sanity,sanity.system,sanity.openjdk aix jdk8,jdk11,jdk16 |
|
Also tested via internal build build_info.php?build_id=6465 with no issues found. |
keithc-ca
reviewed
Jun 8, 2021
keithc-ca
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack protect is enabled for gcc builds but not yet for xlc. Enable it for AIX.
@dnakamura pls review the -qstackprotect change.
@hangshao0 pls review the shared classes change.