(0.27.0) Update jit_jitt_array_compress unit test to set -Xmx #13091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test added via eclipse-openj9#12905 uses the -XXgc:forcedShiftingCompressionAmount option to force shifting to 1, 2, 3, 4, but doesn't set -Xmx. The default -Xmx is 25% of the available memory up to 25G. The default value on some machines may be too big for smaller shift values. Issue eclipse-openj9#12947 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
requested review from
fjeremic and
keithc-ca
and removed request for
fjeremic
keithc-ca
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test added via
#12905 uses the
-XXgc:forcedShiftingCompressionAmount option to force shifting to 1, 2,
3, 4, but doesn't set -Xmx. The default -Xmx is 25% of the available
memory up to 25G. The default value on some machines may be too big for
smaller shift values.
Issue #12947
Cherry pick of #13090 for the 0.27 release.