Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable verbose gc log for -Xlog levels trace, debug, info #13866

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Nov 4, 2021

Levels off, warning, error do not enable the verbose gc log

Issue #13865

@pshipton
Copy link
Member Author

pshipton commented Nov 4, 2021

jenkins compile alinux64 jdk11

@pshipton
Copy link
Member Author

pshipton commented Nov 4, 2021

@pshipton
Copy link
Member Author

pshipton commented Nov 4, 2021

jenkins compile zlinux,win jdk11

@pshipton
Copy link
Member Author

pshipton commented Nov 5, 2021

@keithc-ca
Copy link
Contributor

https://www.eclipse.org/openj9/docs/xlog/ doesn't mention any legal suffixes for -Xlog:gc, and I couldn't find any documentation for other implementations that would suggest we should consider off, or any of the levels recognized by this change. Please provide some more context so I can understand the motivation here.

@pshipton
Copy link
Member Author

pshipton commented Nov 8, 2021

See "Available log levels" at https://docs.oracle.com/en/java/javase/11/tools/java.html#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5
Only one level can be specified, and with the exception of off, the level includes all the lower levels. i.e. setting warning also enables error, etc.
This PR is based on my judgment call that the error and warning levels should not enable the OpenJ9 verbose gc log.

runtime/vm/jvminit.c Outdated Show resolved Hide resolved
Levels off, warning, error do not enable the verbose gc log

Issue eclipse-openj9#13865

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Nov 8, 2021

jenkins compile alinux64 jdk11

@pshipton
Copy link
Member Author

pshipton commented Nov 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants