Tidy up CRIU support #13934
Merged
Tidy up CRIU support #13934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
Nov 16, 2021
runtime/vm/criuhelpers.cpp
Outdated
| @@ -61,16 +61,17 @@ jvmCheckpointHooks(J9VMThread *currentThread) | |||
| BOOLEAN | |||
| jvmRestoreHooks(J9VMThread *currentThread) | |||
| { | |||
| #if defined(J9VM_OPT_CRIU_SUPPORT) | |||
There was a problem hiding this comment.
Can we put this entire function under a single #ifdef? There is no reason for this function here to be called if the CRIU flag is not enabled.
There was a problem hiding this comment.
Sure, I can do that (I was just maintaining the set of functions defined).
There was a problem hiding this comment.
The file is now only compiled if CRIU support is configured.
|
Adding Irwin to review the JIT changes |
dsouzai
reviewed
Nov 16, 2021
* inline CRIU checkpoint state (only if needed) * add missing #endif comments * compile criuhelpers.cpp only if CRIU support is configured * only declare functions when they will be defined Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
tajila
approved these changes
Nov 17, 2021
|
Jenkins test sanity win jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#endifcomments