-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up CRIU support #13934
Tidy up CRIU support #13934
Conversation
runtime/vm/criuhelpers.cpp
Outdated
@@ -61,16 +61,17 @@ jvmCheckpointHooks(J9VMThread *currentThread) | |||
BOOLEAN | |||
jvmRestoreHooks(J9VMThread *currentThread) | |||
{ | |||
#if defined(J9VM_OPT_CRIU_SUPPORT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put this entire function under a single #ifdef
? There is no reason for this function here to be called if the CRIU flag is not enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can do that (I was just maintaining the set of functions defined).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is now only compiled if CRIU support is configured.
Adding Irwin to review the JIT changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No functional changes added to JIT, so LGTM for the JIT files.
* inline CRIU checkpoint state (only if needed) * add missing #endif comments * compile criuhelpers.cpp only if CRIU support is configured * only declare functions when they will be defined Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Jenkins test sanity win jdk8 |
#endif
comments