Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonexistent data from relo log format string #13960

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Nov 19, 2021

The relocation debug dump code for
TR_ValidateStackWalkerMaySkipFramesRecord incorrectly tried to also
print out a beholderMethod even though there isn't one.

Signed-off-by: Irwin D'Souza dsouzai.gh@gmail.com

The relocation debug dump code for
TR_ValidateStackWalkerMaySkipFramesRecord incorrectly tried to also
print out a beholderMethod even though there isn't one.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 19, 2021

@jdmpapin could you please review?

@jdmpapin
Copy link
Contributor

Jenkins test sanity all jdk17

@jdmpapin jdmpapin self-assigned this Nov 19, 2021
@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 22, 2021

Both x86 and ppc64le fail for the same reason:

[Pipeline] stage
[Pipeline] { (Build)
[Pipeline] timestamps
[Pipeline] {
[Pipeline] echo
[2021-11-19T22:48:36.823Z] Building tests...
[Pipeline] timeout
[2021-11-19T22:48:36.827Z] Timeout set to expire in 1 hr 0 min
[Pipeline] {
[Pipeline] copyArtifacts
[2021-11-19T22:49:30.254Z] Copied 1 artifact from "Test_openjdk17_j9_sanity.functional_ppc64le_linux_Personal" build number 54
[Pipeline] }
[Pipeline] // timeout
[Pipeline] timeout
[2021-11-19T22:49:31.171Z] Timeout set to expire in 1 hr 0 min
[Pipeline] {
[Pipeline] copyArtifacts
[2021-11-19T23:49:31.171Z] Cancelling nested steps due to timeout
[Pipeline] }
[Pipeline] // timeout
[Pipeline] echo
[2021-11-19T23:49:37.023Z] Cannot run copyArtifacts from test.getDependency. Skipping copyArtifacts...
[Pipeline] fileExists
[Pipeline] fileExists
[Pipeline] withCredentials
[2021-11-19T23:49:42.324Z] Masking supported pattern matches of $USERNAME or $PASSWORD
[Pipeline] {
[Pipeline] dir
[2021-11-19T23:49:42.336Z] Running in /home/****/workspace/Test_openjdk17_j9_sanity.functional_ppc64le_linux_Personal_testList_1/aqa-tests
[Pipeline] {
[Pipeline] sshagent
[2021-11-19T23:49:42.350Z] [ssh-agent] Looking for ssh-agent implementation...
[2021-11-19T23:54:43.867Z] Could not find ssh-agent: InterruptedException: null
[2021-11-19T23:54:43.867Z] [ssh-agent] FATAL: Could not find a suitable ssh-agent provider
[2021-11-19T23:54:43.867Z] [ssh-agent] Diagnostic report
[Pipeline] // sshagent
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Post)
[Pipeline] timestamps
[Pipeline] {
[Pipeline] step
[2021-11-19T23:54:46.862Z] TAP Reports Processing: START
[2021-11-19T23:54:46.863Z] Looking for TAP results report in workspace using pattern: **/*.tap
[2021-11-19T23:55:30.709Z] Did not find any matching files. Setting build result to FAILURE.

which appears to be infra related.

@dsouzai
Copy link
Contributor Author

dsouzai commented Nov 22, 2021

@jdmpapin this should be ok to merge as well.

@jdmpapin
Copy link
Contributor

As @dsouzai mentioned, the x86-64 and ppc64le Linux failures are just an ssh-agent (i.e. infra) problem preventing testList_1 from running. All other builds and tests have succeeded, including the builds and testList_0 tests on both of those platforms. Merging despite the two failures because this is an extremely straightforward fix to tracing logic that only runs when traceRelocatableDataDetailsCG is enabled

@jdmpapin jdmpapin merged commit fb29874 into eclipse-openj9:master Nov 22, 2021
@dsouzai dsouzai deleted the reloDumpFmtString branch February 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants