-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add java option to ensure classes are hashed #14042
Conversation
* Introduce java option `-XX:[+|-]EnsureHashed:<class>,...` * Store classes in table, tag them upon load * Inline allocator sets "has been hashed" bit for objects allocated of these classes * OOL allocator allocates and initializes the hash slot Closes: eclipse-openj9#13029 Signed-off-by: Eric Yang <eric.yang@ibm.com>
The crash in #13939 appears to be fixed with the second commit. Investigation is still underway to determine the reason. |
Can you open a new issue for the |
#14043 tracks the investigation |
Ran zOS and windows sanity.functional builds and all passed (tests that previously would have failed have passed). https://hyc-runtimes-jenkins.swg-devops.com/job/jvm.29.personal/30157/ |
runtime/oti/j9nonbuilder.h
Outdated
@@ -3224,6 +3225,9 @@ typedef struct J9Class { | |||
#define J9CLASS_PREPADDING_SIZE(clazz) 0 | |||
#endif /* defined(J9VM_OPT_VALHALLA_VALUE_TYPES) */ | |||
|
|||
/* For the following, J9_ARE_ANY_BITS_SET fails on zOS, currently under investigation */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the issue number to this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
e3688af
to
c461d1f
Compare
Jenkins test sanity win jdk8 |
Jenkins test sanity,extended plinux jdk17 |
@EricYangIBM Please make a PR for the 0.30 branch |
We need the documentation PRs created for this. Both for https://github.com/eclipse-openj9/openj9-docs, including the release notes for 0.30.0, and also in https://github.com/eclipse-openj9/openj9/blob/master/doc/release-notes/0.30/0.30.md |
The docs PR is here, eclipse-openj9/openj9-docs#827 |
@EricYangIBM Can you open a PR to add this to the release notes |
See eclipse-openj9#14042 Signed-off-by: Eric Yang <eric.yang@ibm.com>
PR created |
See eclipse-openj9#14042 Signed-off-by: Eric Yang <eric.yang@ibm.com>
-XX:[+|-]EnsureHashed:<class>,...
these classes
Closes: #13029
Signed-off-by: Eric Yang eric.yang@ibm.com