Allow more expensive hot compilations under -Xtune:throughput #14563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables two changes for hot/scorching compilations performed under the -Xtune:throughput mode: 1. -Xjit:acceptHugeMethod is enabled, allowing more complex methods to be successfuly compiled. This change can be disabled by setting the following environment variable: TR_DontAcceptHugeMethods=1 2. The JIT scratch memory limit is increased from 256 MB to 512 MB allowing compilations that need more memory to succeed. The new scratch memory limit value for hot compilations can be controlled with -Xjit:scratchSpaceLimitKBForHotCompilations=<NNN> Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
mpirvu
force-pushed
the
accept-huge-methods
branch
from
05dbd73
to
a73ea43
Compare
|
FYI: @vijaysun-omr |
|
Jenkins test extended all jdk11 |
|
Jenkins test sanity all jdk11 |
vijaysun-omr
approved these changes
Feb 19, 2022
|
Jenkins test extended all jdk11 |
|
Jenkins test extended alinux64 jdk11 |
|
The AArch64 jobs seem to have hit some infra issue. I am going to merge this since this affects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables two changes for hot/scorching compilations
performed under the -Xtune:throughput mode:
-Xjit:acceptHugeMethod is enabled, allowing more complex methods
to be successfuly compiled. This change can be disabled by setting
the following environment variable: TR_DontAcceptHugeMethods=1
The JIT scratch memory limit is increased from 256 MB to 512 MB
allowing compilations that need more memory to succeed. The new
scratch memory limit value for hot compilations can be controlled
with -Xjit:scratchSpaceLimitKBForHotCompilations=
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com