Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude testSharedCacheJvmtiAPI on AArch64 macOS #14591

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 24, 2022

This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Feb 24, 2022

How can I exclude a specific subtest?

I tried to exclude testSharedCacheJvmtiAPI only, but I was not able to find how to do it.
OpenJ9 AArch64 macOS passes all the tests in testSCCacheManagement but testSharedCacheJvmtiAPI.

@pshipton
Copy link
Member

How can I exclude a specific subtest?

@llxia may know, or we could modify the test code to do nothing on amac. If we can't exclude the sub-test, modifying the test is my preference over excluding the entire suite.

@llxia
Copy link
Contributor

llxia commented Feb 24, 2022

We can add if statement in the test in

public void testSharedCacheJvmtiAPI() { TestSharedCacheJvmtiAPI.main(null); }

to

public void testSharedCacheJvmtiAPI() {
	String spec = System.getenv("SPEC");
	if (!spec.contains("osx_aarch64")) {
		TestSharedCacheJvmtiAPI.main(null);
	}
}

This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k changed the title Exclude testSCCacheManagement on AArch64 macOS Exclude testSharedCacheJvmtiAPI on AArch64 macOS Feb 25, 2022
@knn-k
Copy link
Contributor Author

knn-k commented Feb 25, 2022

jenkins test extended.functional amac jdk18

@knn-k
Copy link
Contributor Author

knn-k commented Feb 25, 2022

@llxia Thank you, I changed the test code as you suggested. I also changed the commit title and the commit message.

@knn-k
Copy link
Contributor Author

knn-k commented Feb 25, 2022

The test job finished successfully on AArch64 macOS, and the result contains testSCCacheManagement_0 as I intended.
https://openj9-jenkins.osuosl.org/job/Build_JDK18_aarch64_mac_Personal/8/

knn-k added a commit to knn-k/openj9 that referenced this pull request Feb 25, 2022
This commit excludes testSharedCacheJvmtiAPI in extended.functional on
AArch64 macOS for the time being, because it is a JVMTI-related test.

Original PR in master: eclipse-openj9#14591

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@pshipton pshipton merged commit 038e689 into eclipse-openj9:master Feb 25, 2022
@knn-k knn-k deleted the aarch64macos_excludes5 branch February 25, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants