-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIU j9time_nano_time skips the elapsed time between Checkpoint/Restore #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
May 6, 2022
tajila
reviewed
May 6, 2022
JasonFengJ9
changed the title
CRIU j9time_nano_time skips the elapsed time between Snapshot/Restore
CRIU j9time_nano_time skips the elapsed time between Checkpoint/Restore
May 6, 2022
can you add test cases for this? |
JasonFengJ9
force-pushed
the
timedelta
branch
2 times, most recently
from
May 12, 2022 14:25
066ee26
to
21a62ae
Compare
Added a test, will need a rebase after merging #14824. |
JasonFengJ9
force-pushed
the
timedelta
branch
2 times, most recently
from
May 17, 2022 12:17
40855e1
to
765b17d
Compare
Resolved the merge conflict. |
tajila
reviewed
May 17, 2022
tajila
reviewed
May 19, 2022
tajila
reviewed
May 19, 2022
test/functional/cmdLineTests/criu/src/org/openj9/criu/TimeChangeTest.java
Show resolved
Hide resolved
Added a field checkpointRestoreTimeDelta within J9PortLibrary, which is to be set the time delta between Checkpoint and Restore of j9time_nano_time() return values; Updated trace points to record the actual j9time_nano_time() values; Add a test to verify the elapsed time. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
tajila
approved these changes
May 20, 2022
Jenkins test sanity xlinuxcriu jdk11 |
Jenkins test sanity win jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a field
checkpointRestoreTimeDelta
withinJ9PortLibrary
, which is to be set the time delta betweenCheckpoint
andRestore
ofj9time_nano_time()
return values;Updated trace points to record the actual
j9time_nano_time()
values.This is first part to address the issue #14211, for
System.nanoTime()
.Tested w/ following code snippet:
Snapshot run w/
-Xtrace:print={j9criu}
Multiple restores
Signed-off-by: Jason Feng fengj@ca.ibm.com