Fix tracepoint matching #15031
Merged
Fix tracepoint matching #15031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, before this change:
* these two options do the same thing even though there is no group
named "staticmethodsXXXX":
"-Xtrace:print=mt,methods=java/lang/System.*,trigger=group{staticmethods,jstacktrace}"
"-Xtrace:print=mt,methods=java/lang/System.*,trigger=group{staticmethodsXXXX,jstacktrace}"
* encountering tracepoint "j9utilcore.0" would trigger a java core
if this option is used
"-Xtrace:trigger=tpnid{j9util.0,javadump}"
Don't match abbreviated trace component names: use j9_cmdla_stricmp()
instead of j9_cmdla_strnicmp() where appropriate.
Also remove redundant, inappropriate casts.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
jenkins compile win jdk8 |
|
Internal testing via 28455 looks good. |
pshipton
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, before this change:
staticmethodsXXXX:j9utilcore.0would trigger a java core if this option is usedDon't match abbreviated trace component names: use j9_cmdla_stricmp() instead of
j9_cmdla_strnicmp()where appropriate.Also remove redundant, inappropriate casts.