Ensure calls to feGetEnv are cached #15194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to feGetEnv are usually cached in static variables. This PR catches a few instances that were not.
|
Jenkins test sanity all jdk17 |
0xdaryl
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to feGetEnv are usually cached in static variables. There were a few cases where the variables weren't declared static and so more calls to getenv were being made than was necessary. These were mostly fixed in OMR PR eclipse/omr#6545, but I also noticed two cases in OpenJ9 code that are addressed in this PR.
The call in initializeProcessorType is probably not much of a problem as it seems likely that the containing function is only called once per JVM instantiation. I've fixed it for completeness as there's hopefully not much downside and it will make any future code review for missed statics a little easier.
The read of TR_silentEnv in feGetEnv2 itself is hopefully ok for caching too - I couldn't see any reason to read it on every call.
Personal build ok: 29935