AArch64: Handle interface call case when patching call site on recompilation #15242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira1Saitoh
force-pushed
the
aarch64InterfaceCallCache
branch
from
e673a3a
to
a324bbd
Compare
Akira1Saitoh
force-pushed
the
aarch64InterfaceCallCache
branch
from
a324bbd
to
c66fcf3
Compare
|
@knn-k Can you please review? |
knn-k
reviewed
Jun 8, 2022
knn-k
reviewed
Jun 8, 2022
…ilation We use 2 cache slots for interface calls and when the cache hit, `blr` instruction is used for the call. The function for updating the callsite on recompilation did not handle such case and failed to update it silently. This commit adds the code to support interface call case. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64InterfaceCallCache
branch
from
c66fcf3
to
2f7e12e
Compare
|
Jenkins test sanity.functional,extended.functional alinux64 jdk17 |
|
Jenkins test sanity.system,extended..system amac jdk17 |
|
Jenkins test sanity.functional,extended.functional alinux64 jdk11 |
|
Jenkins test sanity.system,extended.system amac jdk11 |
|
The following tests passed:
|
knn-k
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 2 cache slots for interface calls and when the cache hit,
blrinstructionis used for the call. The function for updating the callsite on recompilation
did not handle such case and failed to update it silently.
This commit adds the code to support interface call case.
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com