Skip halt check after explict GC, with external exclusive VM access #15271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If caller of explicit GC (for example RAS) already obtained exclusive VM access, checking if we the thread needs to halt after completing the GC could lead to a deadlock. For example exclusive VM access could prevent an inspector thread to proceed, while also this thread just blocked expecting to be inspected. The fix is to make an excpetion and skip the halt check if we know that we hold exclusive VM access. Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
gacholio
approved these changes
Jun 8, 2022
|
jenkins test sanity zlinux jdk11 |
dmitripivkine
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If caller of explicit GC (for example RAS) already obtained exclusive VM
access, checking if the thread needs to halt after completing the GC
could lead to a deadlock. For example exclusive VM access could prevent
an inspector thread to proceed, while also this thread just blocked
expecting to be inspected.
The fix is to make an exception and skip the halt check if we know that
we hold exclusive VM access.
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com