Correct reading BuildVersionCommand from OSX core files #15357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not reading the 'platform' field causing misinterpretation of the following fields. The 'sdk' field was read as the number of tools yielding unreasonable values (e.g. 11.3.0 is expressed as 0x000b0300 = 721664), with significant expense of both time and space. Also, the decomposition of versions was incorrect due to off-by-one errors in the loop bounds (e.g. 11.3.0 was decomposed as 0.110.30). Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Note: see |
|
jenkins test extended xmac,amac jdk11 |
|
jenkins test extended xmac,amac jdk11 |
pshipton
approved these changes
Jun 17, 2022
|
This seems a good candidate for 0.33 |
See #15362. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not reading the
platformfield causing misinterpretation of the following fields.The
sdkfield was read as the number of tools yielding unreasonable values (e.g. 11.3.0 is expressed as 0x000b0300 = 721664), with significant expense of both time and space.Also, the decomposition of versions was incorrect due to off-by-one errors in the loop bounds (e.g. 11.3.0 was decomposed as 0.110.30).
(Discovered while investigating #15114).