Add tests in FIPS mode #15372
Merged
Add tests in FIPS mode #15372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilburZjh
force-pushed
the
cmdLineTests4FIPS
branch
2 times, most recently
from
9125ade
to
7854a4c
Compare
llxia
reviewed
Jun 20, 2022
|
|
||
| <test id="Verify providers in FIPS mode"> | ||
| <command>$EXE$ $CLASSPATH$ org.openj9.test.fips.FIPSProvidersTest</command> | ||
| <output type="success" caseSensitive="no" regex="no">Verify providers in FIPS mode COMPLETED</output> |
There was a problem hiding this comment.
Could you fix the indentation? The same for the rest of PR.
| <delete dir="${build}" /> | ||
| </target> | ||
|
|
||
| <target name="build" depends="buildCmdLineTestTools"> |
There was a problem hiding this comment.
I do not see buildCmdLineTestTools is defined anywhere.
| </groups> | ||
| <impls> | ||
| <impl>openj9</impl> | ||
| </impls> |
There was a problem hiding this comment.
Do we want to run against JDK8? If not, please add
<versions>
<version>11+</version>
</versions>
| </impls> | ||
| </test> | ||
| <test> | ||
| <testCaseName>cmdLineTester_fips_importAndExtractKeys</testCaseName> |
There was a problem hiding this comment.
All tests are defined in fips.xml, so we only need one <test> in playlist.xml.
WilburZjh
force-pushed
the
cmdLineTests4FIPS
branch
2 times, most recently
from
ef4bdf3
to
007b7ff
Compare
llxia
reviewed
Jun 22, 2022
| --> | ||
| <playlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../TKG/playlist.xsd"> | ||
| <test> | ||
| <testCaseName>cmdLineTester_fips_providers</testCaseName> |
There was a problem hiding this comment.
Since we merge tests into one target, should we call it - cmdLineTester_fips?
Signed-off-by: Jinhang Zhang <Jinhang.Zhang@ibm.com>
WilburZjh
force-pushed
the
cmdLineTests4FIPS
branch
from
007b7ff
to
7377459
Compare
|
with FIPS: Grinder_FIPS/48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three tests in FIPS mode.
FIPSProviderTestaims to ensure that a program in FIPS mode has 4 providers and they are the right ones.FIPSKeyExtractImportwithencryptargs aims to make sure that importing secret keys work in FIPS mode.FIPSKeyExtractImportwithextractkeyargs aims to check that extracting RSA keys work in FIPS mode.