Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenSSL to 1.1.1q #15484

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Update OpenSSL to 1.1.1q #15484

merged 2 commits into from
Jul 5, 2022

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Jul 5, 2022

No description provided.

@pshipton
Update OpenSSL to 1.1.1q
f488d98 
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Jul 5, 2022

jenkins compile all jdk11

@pshipton
Use openssl 1.1.1p for amac
bde361f 
1.1.1q doesn't compile, and the security vulnerability fixed in 1.1.1q
doesn't impact OpenJ9.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Jul 5, 2022 •
edited

The builds passed for all platforms except amac (https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/2389/). Since the vulnerability fixed in 1.1.1q doesn't affect OpenJ9 builds, and this platform is early access, a quick workaround is to keep using 1.1.1p for amac while updating all the other platforms to 1.1.1q just so they are using the latest.
This change was tested for amac in a personal build https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/199/

09:17:01  test/v3ext.c:201:24: error: implicitly declaring library function 'memcmp' with type 'int (const void *, const void *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
09:17:01          if (!TEST_true(memcmp(ip1->data, ip2->data, ip1->length) <= 0))
09:17:01                         ^
09:17:01  test/v3ext.c:201:24: note: include the header <string.h> or explicitly provide a declaration for 'memcmp'

@pshipton pshipton requested a review from tajila July 5, 2022 15:18
@tajila tajila merged commit a9bdd6d into eclipse-openj9:master Jul 5, 2022
@pshipton pshipton mentioned this pull request Jul 5, 2022
Merged
pshipton added a commit to pshipton/openj9 that referenced this pull request Jul 12, 2022
@pshipton
Use OpenSSL 1.1.1p for xmac
103bcdb 
After eclipse-openj9#15433 was merged,
1.1.1q on xmac no longer compiles. See also
eclipse-openj9#15484 (comment)

The problem is already fixed in OpenSSL for the next release.
openssl/openssl@f9e578e720

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pshipton @tajila