Relocate clearNonZAAPEligibleBit implementation to vm_scar.c #15551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current home of `clearNonZAAPEligibleBit` implementation in java_dyn_methodhandle.c is only compiled if J9VM_OPT_METHOD_HANDLE is set. Moving the implementation to vm_scar.c as a more generic home that is always compiled, to avoid any unresolved symbol errors during linking when J9VM_OPT_METHOD_HANDLE is not set. Signed-off-by: Joran Siu <joransiu@ca.ibm.com>
|
This change only impacts zOS. Two clean internal zOS JDK8/11 personal builds with the changes:
|
pshipton
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current home of
clearNonZAAPEligibleBitimplementation in java_dyn_methodhandle.cis only compiled if
J9VM_OPT_METHOD_HANDLEis set. Moving the implementation to vm_scar.cas a more generic home that is always compiled, to avoid any unresolved symbol errors
during linking when
J9VM_OPT_METHOD_HANDLEis not set.Signed-off-by: Joran Siu joransiu@ca.ibm.com