Add option to decompress() for variable length #15618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was tested internally, I don't see any point it running testing again. @keithc-ca any concerns before this is merged? |
keithc-ca
reviewed
Jul 26, 2022
mikezhang1234567890
force-pushed
the
string
branch
2 times, most recently
from
7a61aa8
to
a3dab8e
Compare
|
Updated PR to pass a length variable to |
mikezhang1234567890
changed the title
mikezhang1234567890
force-pushed
the
string
branch
from
a3dab8e
to
4f6f3f3
Compare
keithc-ca
reviewed
Jul 28, 2022
mikezhang1234567890
force-pushed
the
string
branch
3 times, most recently
from
becf4fd
to
1c26f5e
Compare
|
@KeithCa updated the PR to address the review comments, can you take another look please? Internal testing done here. |
keithc-ca
requested changes
Aug 4, 2022
mikezhang1234567890
force-pushed
the
string
branch
2 times, most recently
from
cad3fc1
to
7e97b12
Compare
|
Updated PR to address comments. Also fixed some comments mixing up StringBuilder/StringBuffer and the trailing whitespace. |
keithc-ca
reviewed
Aug 4, 2022
mikezhang1234567890
force-pushed
the
string
branch
2 times, most recently
from
e859bc7
to
dd65a80
Compare
keithc-ca
requested changes
Aug 8, 2022
mikezhang1234567890
force-pushed
the
string
branch
from
dd65a80
to
f5c8513
Compare
keithc-ca
reviewed
Aug 9, 2022
mikezhang1234567890
force-pushed
the
string
branch
from
f5c8513
to
06c644a
Compare
keithc-ca
reviewed
Aug 9, 2022
In StringBuilder and StringBuffer, decompress() usually only works up to the current data length. However, methods like move() can place characters past the current length, so add a parameter to decompress() in order to specify the number of characters that are decompressed. Fixes issues with insert() method when compact strings is enabled and the caller has compressed storage and the inserted object is not compressed. Also corrects some spelling of variable names and fixes some comments mixing up StringBuilder and StringBuffer. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
mikezhang1234567890
force-pushed
the
string
branch
from
06c644a
to
4113c5a
Compare
|
jenkins test sanity zlinux jdk8 |
keithc-ca
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In StringBuilder and StringBuffer, decompress() usually only works up
to the current data length. However, methods like move() can place
characters past the current length, so add a parameter to decompress()
in order to specify the number of characters that are decompressed.
Fixes issues with insert() method when compact strings is enabled and
the caller has compressed storage and the inserted object is not
compressed.
fyi: @pshipton