Fix issue in java.lang.Thread.getThreads #15619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #15321 |
tajila
approved these changes
Jul 26, 2022
|
jenkins test sanity win,plinux jdk19 |
|
I suspect this may also fix #15355 |
|
The failures all occur with sanity.openjdk jenkins test sanity.openjdk all jdk19 |
gacholio
previously approved these changes
Jul 26, 2022
|
Actually, this code is not correct - as soon as exclusive is released, you can no longer depend on the validity of the J9VMThread structures. |
|
A yuckier (but correct) solution would be to make JNI refs from all of the threadObject values and unwrap them into the final array. Creation of JNI local refs will work while holding exclusive. |
gacholio
reviewed
Jul 27, 2022
Current code holds pointers to thread objects across the call to allocate the returned array. This results in ptentially returning invalid pointers if the allocation results in a GC. Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
gacholio
approved these changes
Jul 28, 2022
|
jenkins test sanity.openjdk win jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code holds pointers to thread objects across the call to
allocate the returned array. This results in ptentially returning invalid
pointers if the allocation results in a GC.
Signed-off-by: Devin Nakamura devinn@ca.ibm.com