Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call setContinuation before/after entry #15642

Merged
merged 1 commit into from Aug 10, 2022
Merged

Call setContinuation before/after entry #15642

merged 1 commit into from Aug 10, 2022

Conversation

fengxue-IS
Copy link
Contributor

  • remove Continuation from requiredClasses list

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

@fengxue-IS
Call setContinuation before/after entry
3e54a78 
- remove Continuation from requiredClasses list

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS fengxue-IS marked this pull request as ready for review August 8, 2022 19:08
@fengxue-IS
Copy link
Contributor Author

@babsingh can you please take a first look

@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Aug 8, 2022
babsingh
babsingh reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uncommented code-block looks fine to me. There is just one doubt about the finally block.

jcl/src/java.base/share/classes/jdk/internal/vm/Continuation.java Show resolved Hide resolved
@babsingh
Copy link
Contributor

babsingh commented Aug 9, 2022

jenkins test sanity amac jdk19

@babsingh
Copy link
Contributor

babsingh commented Aug 9, 2022

jenkins test sanity win jdk19

@babsingh babsingh merged commit 0cca472 into eclipse-openj9:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
project:loom Used to track Project Loom related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fengxue-IS @babsingh