New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer local compilations in more cases #15644
Conversation
Attn @mpirvu. The fix you suggested appears to work. |
Great! |
Actually, my suggested fix was to provide the correct startPC to |
Oh, sure. I can make that change too. I only tried one of the failing tests ( |
6d4187d
to
6d7b058
Compare
The failing tests on X all pass. I haven't tried power yet, but I doubt that will make a difference. |
When the tests passed, did you have both the "startPC" change and the change in heuristics in |
I haven't tested only the |
It appears to segfault still, but in a slightly different way:
|
That's bad. The heuristic change only masks the problem which appears when a recompilation is scheduled, so we need to fix the actual problem. |
Since the crash is exactly in |
6d7b058
to
274bfc9
Compare
Please rebase so that I can start testing. |
Rebase this one on #15686? |
Oh, I see that the other PR has been merged now. |
We now prefer to compile locally when local sync compilation is enabled and the method in question is cold and synchronous. A function was also passed the incorrect pc when adding a remote compilation request. This was also fixed. Signed-off-by: Christian Despres <despresc@ibm.com>
274bfc9
to
bfd3fd3
Compare
Rebased onto master. |
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17 |
Tests have passed. Hence, merging. |
We now prefer to compile locally when local sync compilation
is enabled and the method in question is cold and synchronous.
A function was also passed the incorrect pc when adding a remote
compilation request. This was also fixed.
Signed-off-by: Christian Despres despresc@ibm.com