Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRIU delay Thread.interrupt() in single thread mode #15648

Merged
merged 1 commit into from Aug 8, 2022
Merged

CRIU delay Thread.interrupt() in single thread mode #15648

merged 1 commit into from Aug 8, 2022

Conversation

JasonFengJ9
Copy link
Member

Added J9_SINGLE_THREAD_MODE_OP_INTERRUPT;
Saved Thread instances to delayedLockingOperationsRoot queue;
CRIUHelpers refactoring ;
Added tests.

closes #15538

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added comp:vm criu Used to track CRIU snapshot related work labels Aug 3, 2022
@JasonFengJ9 JasonFengJ9 requested a review from tajila August 3, 2022 12:22
tajila
tajila reviewed Aug 3, 2022
View reviewed changes
runtime/oti/VMHelpers.hpp Outdated Show resolved Hide resolved
runtime/vm/CRIUHelpers.cpp Show resolved Hide resolved
runtime/vm/CRIUHelpers.cpp Outdated Show resolved Hide resolved
@JasonFengJ9 JasonFengJ9 force-pushed the delayinterrupt branch 2 times, most recently from 289c422 to 98319a4 Compare August 3, 2022 18:49
tajila
tajila reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@tajila tajila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In monitorWaitImpl we should also detect if we are interupted in single thread mode due to spurious interupts and wait again.

@JasonFengJ9 JasonFengJ9 force-pushed the delayinterrupt branch 2 times, most recently from f9821ad to 73c7ae1 Compare August 5, 2022 13:04
@JasonFengJ9
Copy link
Member Author

Updated monitorWaitImpl & jvmtiRawMonitorWait to handle spurious interruptions.
@tajila this is ready for another look.

tajila
tajila reviewed Aug 8, 2022
View reviewed changes
runtime/jcl/common/thread.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Show resolved Hide resolved
@JasonFengJ9
CRIU delay Thread.interrupt() in single thread mode
8c58a9d 
Added J9_SINGLE_THREAD_MODE_OP_INTERRUPT;
Saved Thread instances to delayedLockingOperationsRoot queue;
Continue waiting if interrupted spuriously in single thread
mode;
Added tests.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@tajila
Copy link
Contributor

tajila commented Aug 8, 2022

Jenkins test sanity xlinuxcriu jdk17

@tajila
Copy link
Contributor

tajila commented Aug 8, 2022

failures are known failures

@tajila tajila merged commit fd3d5d0 into eclipse-openj9:master Aug 8, 2022
@JasonFengJ9 JasonFengJ9 deleted the delayinterrupt branch August 8, 2022 19:52
@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila left review comments

Assignees
No one assigned
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRIU: delay interrupt requests to hatled threads
2 participants
@JasonFengJ9 @tajila