Correct signature of JVM_VirtualThread functions #15717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
approved these changes
Aug 16, 2022
|
jenkins compile win jdk19 |
|
jenkins test sanity amac jdk19 |
tajila
reviewed
Aug 16, 2022
runtime/j9vm/javanextvmi.c
Outdated
| @@ -236,25 +236,25 @@ JVM_IsPreviewEnabled(void) | |||
| } | |||
|
|
|||
| JNIEXPORT void JNICALL | |||
| JVM_VirtualThreadMountBegin(JNIEnv *env) | |||
| JVM_VirtualThreadMountBegin(JNIEnv *env, jobject vthread, jboolean first_mount) | |||
There was a problem hiding this comment.
minor thing with the param naming:
please change first_mount to firstMount and same for the others
There was a problem hiding this comment.
Sure, I'll change the names to match those used by related functions in thread.cpp.
They each expect three parameters (not just one). Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
jenkins test sanity amac jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They all expect three parameters (not just one); see jvm.h.