Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match jdk8 runFinalizersOnExit() and phantom reference behavior #15784

Merged
merged 5 commits into from Aug 30, 2022
Merged

Match jdk8 runFinalizersOnExit() and phantom reference behavior #15784

merged 5 commits into from Aug 30, 2022

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Aug 26, 2022 •
edited

@pshipton pshipton force-pushed the runfinalizers branch 2 times, most recently from 2a9d924 to 99d4fde Compare August 26, 2022 20:37
@pshipton pshipton changed the title runFinalizationOnExit() in jdk8 throws UnsupportedOperationException runFinalizersOnExit() in jdk8 throws UnsupportedOperationException Aug 26, 2022
@pshipton pshipton added the jdk8 label Aug 26, 2022
@pshipton
Copy link
Member Author

jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging

@pshipton pshipton force-pushed the runfinalizers branch 2 times, most recently from 4ff7465 to cb238cf Compare August 26, 2022 21:13
@pshipton
Copy link
Member Author

jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging

@pshipton pshipton changed the title runFinalizersOnExit() in jdk8 throws UnsupportedOperationException Match jdk8 runFinalizersOnExit() and phantom reference behavior Aug 29, 2022
@pshipton
Copy link
Member Author

jenkins test sanity,sanity.openjdk alinux64,zlinux,aix,win,win32 jdk8 depends ibmruntimes/openj9-openjdk-jdk8#openj9-staging

@pshipton
Copy link
Member Author

pshipton commented Aug 29, 2022 •
edited

Running the sanity.openjdk tests from the openj9-staging branch.
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.openjdk_aarch64_linux_Personal/6/ - passed
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.openjdk_ppc64_aix_Personal/9/ - passed
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.openjdk_s390x_linux_Personal/8/ - passed
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.openjdk_x86-32_windows_Personal/6/ - passed
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.openjdk_x86-64_windows_Personal/10/ - passed

@pshipton
Copy link
Member Author

pshipton commented Aug 29, 2022 •
edited

The zlinux sanity.functional tests passed, but because I aborted a restart it appears aborted in the summary. The passing job is
https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK8_s390x_linux/1187/

dmitripivkine
dmitripivkine approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@dmitripivkine dmitripivkine left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GC part of the change looks good to me

@pshipton
Copy link
Member Author

Added a link to the spec change to the description.

@pshipton
Copy link
Member Author

FYI There is now a jdk8u352-b04 level which hasn't yet been tested.

@pshipton
Remove and update runFinalizersOnExit() tests
5423c85 
runFinalizersOnExit() now throws UnsupportedOperationException.
OpenJDK issue 8287132.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Remove runFinalizersOnExit() implementation
65b42e0 
The runFinalizersOnExit() API now throws UnsupportedOperationException.
OpenJDK issue 8287132.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Remove phantom referent when enqueueing in Java 8
1a5bcbe 
Match the behavior of Java 11+

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
j.l.ref.Reference matches jdk11 enqueue() behavior & disallows clone()
a06ffd7 
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Fix jdk8 java.lang.reference tests to match jdk11 behavior
7835b77 
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

Addressed review comments. Rebasing, and I'll run a new jdk8 acceptance build with this change on jdk8u352-b04.

@pshipton
Copy link
Member Author

pshipton commented Aug 30, 2022 •
edited

jkd8 acceptance build with this change https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK8-Acceptance/45/

@pshipton
Copy link
Member Author

jenkins test sanity amac jdk11

@pshipton
Copy link
Member Author

There are a couple of failures in the acceptance build but they appear to be known problems and unrelated to this change.
#14943
#15797

@keithc-ca keithc-ca merged commit 83a6c39 into eclipse-openj9:master Aug 30, 2022
@pshipton pshipton mentioned this pull request Sep 6, 2022
Merged
@pshipton pshipton mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

@dmitripivkine dmitripivkine dmitripivkine approved these changes

Assignees
No one assigned
Labels
comp:gc comp:test comp:vm depends:openjdk8 jdk8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pshipton @keithc-ca @dmitripivkine