Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused JVM_Exit() function #15787

Merged
merged 1 commit into from Aug 30, 2022
Merged

Conversation

keithc-ca
Copy link
Contributor

@keithc-ca keithc-ca commented Aug 29, 2022

The final mention (the declaration in jdk8) is removed by

  • 8287132: Retire Runtime.runFinalizersOnExit so that it always throws UOE

@pshipton
Copy link
Member

Once the jdk8 openjdk level containing the change is promoted, this can be merged.

@keithc-ca
Copy link
Contributor Author

Once the jdk8 openjdk level containing the change is promoted, this can be merged.

Originally, I had expected this would wait for that change to be promoted, but there are currently no uses, only the declaration, so it should be safe to merge now.

@pshipton
Copy link
Member

jenkins compile win jdk8

@pshipton
Copy link
Member

Windows doesn't compile, we need to wait.

14:25:27  jvm_redirect.def : error LNK2001: unresolved external symbol JVM_Exit

@gacholio
Copy link
Contributor

Looks like exports.cmake and j9vmnatives.xml also need the deletion.

@keithc-ca
Copy link
Contributor Author

Looks like exports.cmake and j9vmnatives.xml also need the deletion.

Yes, I just realized that. I will update this shortly.

The final mention (the declaration) is removed by
* 8287132: Retire Runtime.runFinalizersOnExit so that it always throws
UOE

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
Copy link
Contributor Author

Updated; verified with a local build of jdk8 on Windows.

@gacholio
Copy link
Contributor

jenkins compile win jdk8

@gacholio gacholio merged commit e53d18b into eclipse-openj9:master Aug 30, 2022
@keithc-ca keithc-ca deleted the jvm_exit branch August 30, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants