Update jvmtiGetStackTrace to support virtual thread

[thallium]

Refactors vm->internalVMFunctions to vmFuncs
Adds a continuation object parameter to jvmtiInternalGetStackTrace.
If targetThread is not null, the targetThread will be used, otherwise
check if continuation object is not null and use that.

In jvmtiGetStackTrace, adds a check for virtual thread, call
jvmtiInternalGetStackTrace with the corresponding arguments depending
on whether the thread is virtual or not.

Adds an assertion to getVMThread to ensure that targetThread will be
NULL for a virtual thread so the extra call to IS_VIRTUAL_THREAD can be
avoided.

Updates jvmtiGetFrameCount and jvmtiGetFrameLocation to remove the
unnecessary IS_VIRTUAL_THREAD call.

Updates the coding style of surrounding code

Issues: #15759 #15183

Signed-off-by: Gengchen Tuo gengchen.tuo@ibm.com

[thallium]

@fengxue-IS can you please take a look?

[fengxue-IS]

LGTM, can you verify that this change passes all the test under https://github.com/ibmruntimes/openj9-openjdk-jdk19/tree/openj9/test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace

[thallium]

LGTM, can you verify that this change passes all the test under https://github.com/ibmruntimes/openj9-openjdk-jdk19/tree/openj9/test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace

Actually 4 tests failed, 2 are PopFrame failed caused by JVMTI_ERROR_THREAD_NOT_SUSPENDED, and two are unmatched stack trace.

[fengxue-IS]

for unmatched stacktrace, if it is due to Continuation.enter/Continuation.enter0/Continuation.yield0 then that is expected.
PopFrame failed is expected as that have not been updated

[thallium]

In test case 5:
expected: 11, actual: 10 (no stacktrace printed)
In test case 3:
expected:

    {"Ljava/lang/Object;", "wait", "()V"},
    {"Lgetstacktr03;", "dummy", "()V"},
    {"Lgetstacktr03;", "chain", "()V"},
    {"Lgetstacktr03$Task;", "run", "()V"},
    {"Ljava/lang/Thread;", "run", "()V"}

got:

 0: java/lang/Object: wait(JI)V
 1: java/lang/Object: wait()V
 2: getstacktr03: dummy()V
 3: getstacktr03: chain()V
 4: getstacktr03$Task: run()V
 5: java/lang/Thread: run()V

expected:

     {"Ljava/lang/Object;", "wait", "()V"},
    {"Lgetstacktr03;", "dummy", "()V"},
    {"Lgetstacktr03;", "chain", "()V"},
    {"Lgetstacktr03$Task;", "run", "()V"},
    {"Ljava/lang/VirtualThread;", "run", "(Ljava/lang/Runnable;)V"},
    {"Ljava/lang/VirtualThread$VThreadContinuation;", "lambda$new$0", "(Ljava/lang/VirtualThread;Ljava/lang/Runnable;)V"},
    {"Ljava/lang/VirtualThread$VThreadContinuation$$Lambda$31.0x0000000800098810;", "run", "()V"},
    {"Ljdk/internal/vm/Continuation;", "enter0", "()V"},
    {"Ljdk/internal/vm/Continuation;", "enter", "(Ljdk/internal/vm/Continuation;Z)V"}

got:

 0: java/lang/Object: wait(JI)V
 1: java/lang/Object: wait()V
 2: getstacktr03: dummy()V
 3: getstacktr03: chain()V
 4: getstacktr03$Task: run()V
 5: java/lang/VirtualThread: run(Ljava/lang/Runnable;)V
 6: java/lang/VirtualThread$VThreadContinuation: lambda$new$0(Ljava/lang/VirtualThread;Ljava/lang/Runnable;)V
 7: java/lang/VirtualThread$VThreadContinuation$$Lambda$6/0x00000000140577d8: run()V
 8: jdk/internal/vm/Continuation: execute(Ljdk/internal/vm/Continuation;)V

[fengxue-IS]

Based on the stacktrace posted, looks like the unmatched portion is with Object.wait() and Continuation.enter which both uses OpenJ9's implementation, so we can treat those as passed.

[babsingh]

Also, remove markdown syntax from the commit message, and make sure the commit message body is wrapped at 72 chars, where reasonable. Ref: https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md#commit-guidelines.

[babsingh]

jenkins test sanity win,xlinux jdk11,jdk19

[babsingh]

jenkins test sanity win,xlinux jdk11,jdk19

[babsingh]

@thallium PR builds have passed. Did your local reruns of the JVMTI serviceability tests from the extension repo pass with this PR?

[thallium]

@thallium PR builds have passed. Did your local reruns of the JVMTI serviceability tests from the extension repo pass with this PR?

Results stays the same: GetFrameCount and GetFrameLocation passed and GetStackTrace 3/7 passed as expected.