Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinitialize target process info on restore in nonportable mode #15837

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Sep 7, 2022

The TR_X86ProcessorInfo struct is used in a bunch of asserts as sanity
tests to ensure consistency with the Port Library. In a restore run, in
non portable mode, the processor description acquired from the port
library can change; therefore, the TR_X86ProcessorInfo struct also needs
to be reinitialized.

Depends on eclipse/omr#6695

Fixes #15814

The TR_X86ProcessorInfo struct is used in a bunch of asserts as sanity
tests to ensure consistency with the Port Library. In a restore run, in
non portable mode, the processor description acquired from the port
library can change; therefore, the TR_X86ProcessorInfo struct also needs
to be reinitialized.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai dsouzai added comp:jit depends:omr criu Used to track CRIU snapshot related work labels Sep 7, 2022
@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 14, 2022

Jenkins test sanity xlinuxcriu jdk11

@dsouzai
Copy link
Contributor Author

dsouzai commented Sep 14, 2022

@ymanton @tajila could one of you please review/merge?

@tajila tajila merged commit eba53af into eclipse-openj9:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit criu Used to track CRIU snapshot related work depends:omr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRIU: Assertion when restoring intel checkpoint image on amd hardware
2 participants