Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Continuation.yield to use onPinned API #15996

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Update Continuation.yield to use onPinned API #15996

merged 1 commit into from
Sep 28, 2022

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Sep 27, 2022 •
edited by babsingh

Allow the overriden onPinned method to perform non-throw behaviour when
the Continuation is pinned during yield.

Fixes: #15936

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

@fengxue-IS
Copy link
Contributor Author

This change fixes:

java/lang/Thread/virtual/stress/PinALot.java
java/lang/Thread/virtual/Parking.java

java/lang/Thread/virtual/TracePinnedThreads.java now fails with

java.lang.ClassCastException: java.lang.StackWalker$StackFrameImpl incompatible with java.lang.LiveStackFrame

which is due to implementation difference.

@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Sep 27, 2022
@fengxue-IS
Copy link
Contributor Author

@babsingh can you please take a look

@babsingh
Copy link
Contributor

babsingh commented Sep 27, 2022 •
edited

Grammar: Allow the overridden onPinned ...

@fengxue-IS
Update Continuation.yield to use onPinned API
699a33d 
Allow the overriden onPinned method to perform non-throw behaviour when
the Continuation is pinned during yield.

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@babsingh
Copy link
Contributor

jenkins test sanity amac jdk19

@babsingh babsingh merged commit 02c3cf1 into eclipse-openj9:master Sep 28, 2022
@pshipton pshipton mentioned this pull request Sep 28, 2022
Closed
@babsingh babsingh mentioned this pull request Sep 29, 2022
Merged
@pshipton
Copy link
Member

This change was reverted by #16016 to address #16011

@fengxue-IS fengxue-IS mentioned this pull request Oct 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
project:loom Used to track Project Loom related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loom: Failures in pinning stress tests
3 participants
@fengxue-IS @babsingh @pshipton