Fix JVMTI methods #16008
Merged
Fix JVMTI methods #16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See JVMTI spec, https://download.java.net/java/early_access/jdk19/docs/specs/jvmti.html, for confirmation. |
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
f1326cb
to
c62e49e
Compare
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
c62e49e
to
513a4d9
Compare
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
513a4d9
to
b0defb7
Compare
|
Similar changes are being added to the JVMTI resume and suspend functions in #15903. |
|
@gacholio Can you please review these changes? |
gacholio
reviewed
Sep 29, 2022
gacholio
reviewed
Sep 29, 2022
gacholio
reviewed
Sep 29, 2022
|
getVMThread will throw JVMTI_ERROR_INVALID_THREAD if allowNull is FALSE. Moving ENSURE_JTHREAD check inside getVMThread will simplify the change. Let me give it a try. |
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
b0defb7
to
2cf1d06
Compare
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
7 times, most recently
from
1a0abc9
to
1ac8c88
Compare
|
@gacholio Reworked the PR. All earlier comments have been addressed. |
gacholio
reviewed
Sep 30, 2022
gacholio
reviewed
Sep 30, 2022
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
2 times, most recently
from
7406037
to
4642a8d
Compare
|
Will have to retain ENSURE_JTHREAD macro since jvmtiRunAgentThread does not use getVMThread. |
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
4642a8d
to
f40fb61
Compare
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
2 times, most recently
from
b12fb29
to
003df7c
Compare
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
4 times, most recently
from
e5682d0
to
5711401
Compare
|
@gacholio The previous feedback has been addressed. This is ready for review. |
gacholio
reviewed
Oct 3, 2022
gacholio
reviewed
Oct 3, 2022
gacholio
reviewed
Oct 3, 2022
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
4 times, most recently
from
b0f78b8
to
ae0b96d
Compare
- Return JVMTI_ERROR_INVALID_THREAD if the input thread parameter is not a thread object. - Consolidate j.l.Thread and j.l.VirtualThread error-checking within getVMThread. This avoids repeated NULL checking and potentially fetching the current thread. - Convert getVMThread's boolean input parameters to a bit field. - More verbose naming used to avoid ambiguity: IS_JAVA_LANG_THREAD and IS_JAVA_LANG_VIRTUALTHREAD. Fixes: eclipse-openj9#15986 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_GetCurrentContendedMonitor
branch
from
ae0b96d
to
f0c5ffc
Compare
gacholio
approved these changes
Oct 3, 2022
|
jenkins test sanity win jdk8 |
|
jenkins test sanity zlinux jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not a thread object.
getVMThread. This avoids repeated NULL checking and potentially
fetching the current thread.
and IS_JAVA_LANG_VIRTUALTHREAD.
Fixes: #15986
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com