Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init jitTOC on ppc64 #16014

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Init jitTOC on ppc64 #16014

merged 1 commit into from
Oct 18, 2022

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Sep 29, 2022

Init jitTOC on ppc64

Signed-off-by: Tobi Ajila atobia@ca.ibm.com

@tajila
Copy link
Contributor Author

tajila commented Oct 12, 2022

@gacholio changes are ready for another look

@gacholio
Copy link
Contributor

jenkins compile plinux jdk19

@gacholio
Copy link
Contributor

I'm thinking a better solution to this problem would be to not swap in the JIT registers on the initial continuation entry. This would allow any dedicated registers on any platform to be inherited.

@gacholio
Copy link
Contributor

To be clear, on first mount, copy the live JIT registers into the continuation structure (which will now represent the carrier state) but do not copy the continuation ones back to live.

All subsequent mount/unmount operations continue to work as they do today, swaping the values.

@gacholio
Copy link
Contributor

Here's a completely untested suggestion: https://github.com/gacholio/openj9/tree/firstmount

@gacholio gacholio self-requested a review October 17, 2022 16:43
@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Oct 17, 2022
@tajila tajila force-pushed the loom branch 3 times, most recently from 7421290 to d3c1f82 Compare October 17, 2022 19:22
fengxue-IS added a commit to fengxue-IS/openj9 that referenced this pull request Oct 17, 2022
- Enable JIT in VirtualThread tests
- Disable testing on PPC due to known test failure
- PPC testing will be re-enabled with eclipse-openj9#16014

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
@tajila
Copy link
Contributor Author

tajila commented Oct 18, 2022

jenkins test sanity plinux

@tajila
Copy link
Contributor Author

tajila commented Oct 18, 2022

jenkins test sanity plinux jdk19

@babsingh
Copy link
Contributor

Relaunching. Infra issue in the previous PR build: https://openj9-jenkins.osuosl.org/job/Build_JDK19_ppc64le_linux_Personal/40/.

jenkins test sanity plinux jdk19

@gacholio gacholio merged commit b851034 into eclipse-openj9:master Oct 18, 2022
pshipton pushed a commit to pshipton/openj9 that referenced this pull request Dec 7, 2022
- Enable JIT in VirtualThread tests
- Disable testing on PPC due to known test failure
- PPC testing will be re-enabled with eclipse-openj9#16014

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
pshipton pushed a commit to pshipton/openj9 that referenced this pull request Dec 7, 2022
- Enable JIT in VirtualThread tests
- Disable testing on PPC due to known test failure
- PPC testing will be re-enabled with eclipse-openj9#16014

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit project:loom Used to track Project Loom related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants