Add new method Class.isIdentity() #16041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add implementation of Class.isIdentity() 2. Update tests Closes eclipse-openj9#16027 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
hangshao0
added
comp:vm
project:valhalla
|
For potential PR builds, the functional Valhalla tests won't compile at this moment. The compilation errors should be resolved by #16040. |
Closes #eclipse-openj9#16031 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
|
I've closed #16040 and moved all the changes here. |
tajila
reviewed
Oct 5, 2022
| @@ -127,6 +127,10 @@ initializeArrayROMClass(J9ROMArrayClass *romClass, J9UTF8 *className, U_32 array | |||
| NNSRP_SET(romClass->className, className); | |||
| NNSRP_SET(romClass->superclassName, &arrayROMClasses.objectClassName); | |||
| romClass->modifiers = J9AccFinal | J9AccPublic | J9AccClassArray | J9AccAbstract; | |||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | |||
| /* Arrays are always identity classes. */ | |||
| romClass->modifiers |= J9AccClassHasIdentity; | |||
There was a problem hiding this comment.
do we add the flag for non-Arrays as well?
There was a problem hiding this comment.
Yes, for non-array classes it is set here:
openj9/runtime/bcutil/ClassFileOracle.cpp
Lines 817 to 819 in 52ab41f
tajila
approved these changes
Oct 6, 2022
|
Jenkins test sanity,extended xlinuxval jdknext |
|
Jenkins test sanity win jdk8 |
|
Jenkins test sanity plinuxvalst jdknext |
|
The PR build failure is due to #16028. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16027 #16031
Signed-off-by: Hang Shao hangshao@ca.ibm.com