Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: source file extensions must be explicit #16113

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

keithc-ca
Copy link
Contributor

Fix warnings when using cmake 3.20 or newer.
See https://cmake.org/cmake/help/latest/policy/CMP0115.html.

Fix warnings when using cmake 3.20 or newer.
See https://cmake.org/cmake/help/latest/policy/CMP0115.html.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@babsingh
Copy link
Contributor

jenkins compile amac jdk11

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CMP0115 warnings are no longer seen:

01:55:25  CMake Warning (dev) at /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/omr/cmake/modules/OmrTargetSupport.cmake:70 (add_library):
01:55:25    Policy CMP0115 is not set: Source file extensions must be explicit.  Run
01:55:25    "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
01:55:25    command to set the policy and suppress this warning.
01:55:25  
01:55:25    File:
01:55:25  
01:55:25      /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/openj9/runtime/jcl/common/getstacktrace.c

@babsingh babsingh merged commit ab96f4e into eclipse-openj9:master Oct 17, 2022
@keithc-ca keithc-ca deleted the cmp0115 branch October 17, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants