Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a name to the default JITServer AOT cache #16166

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

cjjdespres
Copy link
Contributor

The default name of the AOT cache that a client will request from a JITServer instance is now "default". Formerly it was nameless (the empty string).

Fixes: #16107
Signed-off-by: Christian Despres despresc@ibm.com

The default name of the AOT cache that a client will request from a
JITServer instance is now "default". Formerly it was nameless (the empty
string).

Fixes: eclipse-openj9#16107
Signed-off-by: Christian Despres <despresc@ibm.com>
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu. I think this is the only change in this repository that needs to happen. The documentation still needs to be updated.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Oct 21, 2022
@mpirvu mpirvu self-assigned this Oct 21, 2022
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Oct 21, 2022
@mpirvu
Copy link
Contributor

mpirvu commented Oct 21, 2022

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Oct 23, 2022

jenkins test sanity zlinuxjit jdk17

1 similar comment
@mpirvu
Copy link
Contributor

mpirvu commented Oct 31, 2022

jenkins test sanity zlinuxjit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Oct 31, 2022

The build on zLinux failed again due to infra:

13:45:08  /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/j9jcl/java.base/share/classes/java/security/AccessController.java:24: warning: [removal] AccessControlContext in java.security has been deprecated and marked for removal
13:45:08  import java.security.AccessControlContext.AccessCache;
13:45:08                      ^
13:46:00  Cannot contact rh7-390-3: java.lang.InterruptedException
13:47:53  /usr/bin/bash: line 1: 10313 Killed                  /home/jenkins/bootjdks/jdk17/bin/java -Xms64M -Xmx1600M -Duser.language=en -Duser.country=US -Xshare:auto -Djava.awt.headless=true -Dextlink.spec.version=17 -Djspec.version=17 --limit-modules java.base,jdk.zipfs,java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim --add-modules java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim --module-path /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/buildtools/interim_langtools_modules --patch-module java.base=/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/buildtools/gensrc/java.base.interim --add-exports java.base/sun.reflect.annotation=jdk.compiler.interim --add-exports java.base/jdk.internal.jmod=jdk.compiler.interim --add-exports java.base/jdk.internal.misc=jdk.compiler.interim --add-exports java.base/sun.invoke.util=jdk.compiler.interim --add-exports java.base/jdk.internal.javac=java.compiler.interim --add-exports java.base/jdk.internal.javac=jdk.compiler.interim -m jdk.javadoc.interim/jdk.javadoc.internal.tool.Main -d /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/images/docs/api -use -keywords -notimestamp -serialwarn -encoding ISO-8859-1 -docencoding UTF-8 -breakiterator -splitIndex --system none -javafx --expand-requires transitive --override-methods=summary -tag beaninfo:X -tag revised:X -tag since.unbundled:X -tag spec:X -tag specdefault:X -tag Note:X -tag ToDo:X -tag 'apiNote:a:API Note:' -tag 'implSpec:a:Implementation Requirements:' -tag 'implNote:a:Implementation Note:' -tag param -tag return -tag throws -taglet build.tools.taglet.JSpec\$JLS -taglet build.tools.taglet.JSpec\$JVMS -taglet build.tools.taglet.ModuleGraph -taglet build.tools.taglet.ToolGuide -tag since -tag serialData -tag factory -tag see -taglet build.tools.taglet.ExtLink -taglet build.tools.taglet.Incubating -tagletpath /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/buildtools/jdk_tools_classes --module-source-path "/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/gensrc/*:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/j9jcl/*/linux/classes:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/src/*/linux/classes:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/j9jcl/*/unix/classes:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/src/*/unix/classes:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/j9jcl/*/share/classes:/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/src/*/share/classes" --module java.se,java.smartcardio,jdk.accessibility,jdk.attach,jdk.charsets,jdk.compiler,jdk.crypto.cryptoki,jdk.crypto.ec,jdk.dynalink,jdk.editpad,jdk.httpserver,jdk.incubator.foreign,jdk.incubator.vector,jdk.jartool,jdk.javadoc,jdk.jcmd,jdk.jconsole,jdk.jdeps,jdk.jdi,jdk.jdwp.agent,jdk.jlink,jdk.jpackage,jdk.jshell,jdk.jsobject,jdk.localedata,jdk.management,jdk.management.agent,jdk.naming.dns,jdk.naming.rmi,jdk.net,jdk.nio.mapmode,jdk.sctp,jdk.security.auth,jdk.security.jgss,jdk.xml.dom,jdk.zipfs,openj9.cuda,openj9.dataaccess,openj9.dtfj,openj9.dtfjview,openj9.gpu,openj9.jvm,openj9.sharedclasses,openj9.traceformat,openj9.zosconditionhandling -Xdoclint:all,-missing -Xdoclint/package:-org.w3c.*,-javax.smartcardio -doctitle 'Java<sup>&reg;</sup> Platform, Standard Edition &amp;&nbsp;Java&nbsp;Development&nbsp;Kit<br>Version 17 API Specification' -windowtitle 'Java SE 17 & JDK 17 [ad-hoc build]' -header '<div style="margin-top: 9px;"><strong>Java SE 17 &amp; JDK 17</strong> <br><strong>DRAFT 17.0.5-internal+0-adhoc.jenkins.BuildJDK17s390xlinuxjitPersonal</strong></div>' -bottom '<a href="https://bugreport.java.com/bugreport/">Report a bug or suggest an enhancement</a><br> For further API reference and developer documentation see the <a href="[https://docs.oracle.com/pls/topic/lookup?ctx=javase17&amp;id=homepage](https://docs.oracle.com/pls/topic/lookup?ctx=javase17&id=homepage)" target="_blank">Java SE Documentation</a>, which contains more detailed, developer-targeted descriptions with conceptual overviews, definitions of terms, workarounds, and working code examples. <a href="https://docs.oracle.com/en/java/javase/index.html">Other versions.</a><br> Java is a trademark or registered trademark of Oracle and/or its affiliates in the US and other countries.<br> <a href="{@docroot}/../legal/copyright.html">Copyright</a> &copy; 1993, 2022, Oracle and/or its affiliates, 500 Oracle Parkway, Redwood Shores, CA 94065 USA.<br>All rights reserved. Use is subject to <a href="https://www.oracle.com/java/javase/terms/license/java17speclicense.html">license terms</a> and the <a href="https://www.oracle.com/technetwork/java/redist-137594.html">documentation redistribution policy</a>. <br><strong>DRAFT 17.0.5-internal+0-adhoc.jenkins.BuildJDK17s390xlinuxjitPersonal</strong> <!-- Version 17.0.5-internal+0-adhoc.jenkins.BuildJDK17s390xlinuxjitPersonal -->' -top '<div style="padding: 6px; text-align: center; font-size: 80%; font-family: DejaVu Sans, Arial, Helvetica, sans-serif; font-weight: normal;">This specification is not final and is subject to change. Use is subject to <a href="https://www.oracle.com/java/javase/terms/license/java17speclicense.html">license terms</a>.</div>' -overview /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/docs/JDK_API-overview.html --since 12,13,14,15,16,17 --since-label "New API since JDK 11" -group "OpenJ9" "openj9.*" -group "Java SE" "java.base:java.compiler:java.datatransfer:java.desktop:java.instrument:java.logging:java.management:java.management.rmi:java.naming:java.net.http:java.prefs:java.rmi:java.scripting:java.se:java.security.jgss:java.security.sasl:java.sql:java.sql.rowset:java.transaction.xa:java.xml:java.xml.crypto" -group "JDK" "jdk.*" -quiet > >(/usr/bin/tee -a /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/docs/_javadoc_JDK_API_exec.log) 2> >(/usr/bin/tee -a /home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/docs/_javadoc_JDK_API_exec.log >&2)
13:47:53  gmake[3]: *** [/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/docs/_javadoc_JDK_API_exec.marker] Error 1
13:47:53  Docs.gmk:450: recipe for target '/home/jenkins/workspace/Build_JDK17_s390x_linux_jit_Personal/build/linux-s390x-server-release/support/docs/_javadoc_JDK_API_exec.marker' failed
13:47:53  make/Main.gmk:467: recipe for target 'docs-jdk-api-javadoc' failed
13:47:53  gmake[2]: *** [docs-jdk-api-javadoc] Error 1
13:47:53  gmake[2]: *** Waiting for unfinished jobs....
13:48:25  1 warning
13:48:41  1 warning
13:49:27  
13:49:27  ERROR: Build failed for target 'all' in configuration 'linux-s390x-server-release' (exit code 2)

@mpirvu
Copy link
Contributor

mpirvu commented Oct 31, 2022

Since tests have passed on xlinux and plinux and since this simple PR cannot cause a build failure (especially when builds on other platforms succeed), I am merging this PR.

@mpirvu mpirvu merged commit 9843f61 into eclipse-openj9:master Oct 31, 2022
JIT as a Service automation moved this from In progress to Done Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Development

Successfully merging this pull request may close these issues.

Provide a name for the default JITServer AOT cache
2 participants