Refactor JITServer AOT cache reading #16228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjjdespres
force-pushed
the
persist-refactor
branch
from
fdb0a06
to
12c3592
Compare
|
Attn @mpirvu. |
cjjdespres
force-pushed
the
persist-refactor
branch
from
12c3592
to
3d2a892
Compare
|
I'm still testing this, but something appears to be wrong with |
|
Oh, of course, I use the data of the freshly-allocated record before |
cjjdespres
force-pushed
the
persist-refactor
branch
2 times, most recently
from
3d57f36
to
b55a0cb
Compare
|
I've also unified the |
cjjdespres
force-pushed
the
persist-refactor
branch
from
b55a0cb
to
cf13cdf
Compare
|
I believe this is the outstanding refactoring done. If there's anything that I've forgotten, let me know. |
mpirvu
reviewed
Nov 3, 2022
There was a problem hiding this comment.
LGTM overall except a few minor things (see inline comments).
There are still a few more refactoring opportunities, but they can be addressed later:
SerializedAOTMethodandCachedAOTMethodcould be added to theAOTSerializationRecordandAOTCacheRecordclass hierarchies.- The combination of a key-record map, list head and tail, etc. for each record type in
JITServerAOTCachecould be turned into a single struct template. - Lists of fields per record type could be replaced with arrays indexed by record type in some places.
cjjdespres
force-pushed
the
persist-refactor
branch
2 times, most recently
from
613a184
to
a9d76fc
Compare
|
I believe that is all of the comments addressed. |
AlexeyKhrabrov
suggested changes
Nov 10, 2022
AlexeyKhrabrov
suggested changes
Nov 10, 2022
Signed-off-by: Christian Despres <despresc@ibm.com>
Signed-off-by: Christian Despres <despresc@ibm.com>
cjjdespres
force-pushed
the
persist-refactor
branch
from
a9d76fc
to
be39468
Compare
AlexeyKhrabrov
approved these changes
Nov 10, 2022
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17 |
|
jenkins test sanity plinuxjit jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some of the JITServer AOT cache reading code from the recent #15949.
CachedAOTMethod) have been consolidated into a singleAOTCacheRecord::readRecordfunction template.Related: #16109