Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline jdk/internal/util/Preconditions.checkIndex #16234

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Inline jdk/internal/util/Preconditions.checkIndex #16234

merged 1 commit into from
Nov 2, 2022

Conversation

gita-omr
Copy link
Contributor

@gita-omr gita-omr commented Nov 1, 2022

  • this method contains a simple check whether provided index is greater than 0 and less than provided upper bound. This check lands itself well to various JIT optimizations (e.g. moving out of a loop).

@gita-omr
Inline jdk/internal/util/Preconditions.checkIndex
968e652 
- this method contains a simple check whether provided index is greater
  than 0 and less than provided upper bound. This check lands itself
  well to various JIT optimizations (e.g. moving out of a loop).
@gita-omr
Copy link
Contributor Author

gita-omr commented Nov 1, 2022

Jenkins test sanity all jdk8,jdk11,jdk17,jdk18,jdk19

@gita-omr
Copy link
Contributor Author

gita-omr commented Nov 1, 2022

@jdmpapin @vijaysun-omr fyi

@gita-omr
Copy link
Contributor Author

gita-omr commented Nov 2, 2022

Test_openjdk19_j9_sanity.functional_s390x_linux_Personal has just one failure: 105 - - cmdLineTester_getPid_0

I would presume it's unrelated.

Build_JDK17_s390x_linux_Personal seems to be an environment issue.

@jdmpapin
Copy link
Contributor

jdmpapin commented Nov 2, 2022 •
edited
Loading

The cmdLineTester_getPid_0 failure is unrelated: #11795, #13085, #16098. So we can ignore that one.

Separately, restarting the failed build.

Jenkins test sanity zlinux jdk17

@jdmpapin
Copy link
Contributor

jdmpapin commented Nov 2, 2022

Everything has passed except another cmdLineTester_getPid_0 failure and a JITServer timeout like #14594 (just in testServer instead of testServerUnreachableForAWhile)

@jdmpapin jdmpapin merged commit a31c794 into eclipse-openj9:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysun-omr vijaysun-omr vijaysun-omr approved these changes

@jdmpapin jdmpapin jdmpapin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gita-omr @jdmpapin @vijaysun-omr