Fix use of Thread.resume(), stop(), suspend() in tests for jdk20 #16245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue eclipse-openj9#16213 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Issue eclipse-openj9#16213 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
force-pushed
the
jdk20unsupported
branch
from
03a6ab9
to
564643b
Compare
|
The grinders were run on 03a6ab99488cfb976c10ce8b9500426ae9a25364 which differs only cosmetically from the latest commit here. |
|
Jenkins compile amac jdk17,jdknext |
|
Afaik the compiles won't build these tests, not sure what use they are. Started a grinder on jdk8, just in case there is something incompatible with that version. https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1480/ |
|
That grinder didn't help: it tested Java 8 and consumed fd7e4b9 which predates this change. |
keithc-ca
approved these changes
Nov 2, 2022
|
Proper grinder on jdk8, which passed https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in grinders
jdk20: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1476/
jdk11: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1477
Fixes #16213