-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace libffi/aarch64 with the latest version in GitHub #16252
Replace libffi/aarch64 with the latest version in GitHub #16252
Conversation
The changes aim to resolve the libffi related issue detected on jtreg FFI downcall & upcall tests suites by replacing the outdated version on Aarch64 with the latest version in Github at https://github.com/libffi/libffi/tree/master/src/aarch64 to better support the downcall & upcall with struct in JEP389/424(Foreign Linker API) which is part of the Panama project. The latest committed SHA: c6dc125afba294b9b9613392c492ae18df3ede84 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Note:
Reviewer: @pshipton, @gacholio |
The following files are directly copied from https://github.com/libffi/libffi/tree/master/src/aarch64 and https://github.com/libffi/libffi/blob/master/src/tramp.c:
plus our own setting with updated code specific to Aarch64.
So the copyright & line endings check at https://openj9-jenkins.osuosl.org/job/PullRequest-CopyrightCheck-OpenJ9/6979/console and https://openj9-jenkins.osuosl.org/job/PullRequest-LineEndingsCheck-OpenJ9/6966/console are not required in such case. |
The changes aren't all specific to aarch64, did you test all the platforms? |
Yes, they were verified on all platforms. |
Which Java versions were tested? |
Internal builds: Java8 |
I assume internal means IBM Java 8? You'd better try OpenJ9 Java 8 as well, just in case. Some of the compiler levels are different. |
Yes. It's IBM Java 8.
Will launch personal builds to double-check. |
External personal builds (OpenJ9 Java 8) on all supported platforms passed without libffi related issue. |
jenkins test sanity xmac jdk8 |
The changes aim to resolve the libffi related issue detected on jtreg FFI downcall & upcall
tests suites by replacing the outdated version on Aarch64 with the latest version in Github at
https://github.com/libffi/libffi/tree/master/src/aarch64 to better support the downcall & upcall
with struct in JEP389/424(Foreign Linker API) which is part of the Panama project.
The latest committed SHA: c6dc125afba294b9b9613392c492ae18df3ede84
Signed-off-by: ChengJin01 jincheng@ca.ibm.com